Skip to content

Fix query validation tests to expect correct timestamps#1654

Merged
Apurva Mehta (apurvam) merged 2 commits into
confluentinc:masterfrom
apurvam:fix-query-validation-tests
Jul 27, 2018
Merged

Fix query validation tests to expect correct timestamps#1654
Apurva Mehta (apurvam) merged 2 commits into
confluentinc:masterfrom
apurvam:fix-query-validation-tests

Conversation

@apurvam

@apurvam Apurva Mehta (apurvam) commented Jul 27, 2018

Copy link
Copy Markdown
Contributor

Description

Now that apache/kafka#5423 is merged, our query validation tests fail because they now expect incorrect timestamps for output records of windowed aggregations. This patch updates the test to have the correct expectations for the timestamps.

This should fix the master build.

Testing done

Tests pass.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@apurvam
Apurva Mehta (apurvam) requested a review from a team July 27, 2018 05:16

@rodesai Rohan (rodesai) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apurvam
Apurva Mehta (apurvam) merged commit 7fcd06c into confluentinc:master Jul 27, 2018
Rohan (rodesai) pushed a commit to rodesai/ksql that referenced this pull request Jul 31, 2018
Apurva Mehta (apurvam) pushed a commit that referenced this pull request Jul 31, 2018
Apurva Mehta (apurvam) pushed a commit that referenced this pull request Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants